MAINT: declare that highspy._core supports free-threaded CPython
#2063
Conversation
This allows `highspy` to be imported in a free-threaded CPython (see PEP 703) interpreter without raising a warning and re-enabling the GIL. We've tested thread-safety of this extension module reasonably well in SciPy now, and everything seems fine on all tested platforms (Linux, macOS, Windows and x86-64/arm64).
There was a problem hiding this comment.
This appears to be very welcome, but what's your view @galabovaa and @mathgeekcoder ?
|
If I'm understanding correctly, we're basically just turning off the GIL for everyone. I don't quite know the implications, but it sounds good to me - as long as we assume the user isn't wanting to try anything pathological. We make the same assumption for C++ users etc. anyhow. I'm guessing if we make this change, we no longer need to disable the GIL in |
Almost. I'd phrase it more like "we avoid re-enabling the GIL for everyone globally when using a
No, that would affect users of all Python versions, so I would not touch that. |
|
Thanks @mathgeekcoder and @rgommers , I'm happy with this as it is |
|
Great, thanks for the quick review! |
You're welcome. It should be in the next release of HiGHS, which will come out in a couple of weeks |
This allows
highspyto be imported in a free-threaded CPython interpreter (see PEP 703, https://py-free-threading.github.io/) without raising a warning and re-enabling the GIL. We've tested thread-safety of this extension module reasonably well in SciPy now, and everything seems fine on all tested platforms (Linux, macOS, Windows and x86-64/arm64).The one-line change matches the Pybind11 example at https://py-free-threading.github.io/porting/#declaring-free-threaded-support.